Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default.lang - biome cleanup #7197

Open
wants to merge 4 commits into
base: dev/feature
Choose a base branch
from

Conversation

ShaneBeee
Copy link
Contributor

@ShaneBeee ShaneBeee commented Nov 5, 2024

Description

This PR aims to clean up the biome section in the default lang file:

  • Since Skript is aiming for MC 1.19+, all older biomes have been removed
  • Since the registry system will create names based on vanilla keys, all lang entries that match their vanilla keys have been removed
  • Entries with multiple options have been left
  • Put in alphabetical order
  • Changed some lang entries so their official name is first in the elements (this makes sure when sending a biome it will use the vanilla name first rather than an "option")
  • Nothing here should be a breaking change

Moving forward, new biomes wont need to be added to the lang file since the registry ClassInfo/Parser will create the entires already


Target Minecraft Versions: any
Requirements: none
Related Issues: none

@ShaneBeee ShaneBeee changed the base branch from master to dev/feature November 5, 2024 20:40
@Romitou Romitou added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants