Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge patch to feature to fix tests #7204

Closed
wants to merge 1 commit into from
Closed

Conversation

sovdeeth
Copy link
Member

@sovdeeth sovdeeth commented Nov 8, 2024

Description


Target Minecraft Versions: any
Requirements: none
Related Issues: none

* SoundUtils - handle Sound class for enum/interface

* SoundUtils - fix an error with MC 1.15

* EffPlaySound.sk - add simple test to make sure syntax doesn't throw error

* EffPlaySound - remove reflection and remove to effect class

* EffPlaySound - some changes

* EffPlaySound.sk - fix tests failing
@sovdeeth sovdeeth changed the base branch from master to dev/feature November 8, 2024 20:50
@sovdeeth
Copy link
Member Author

sovdeeth commented Nov 8, 2024

ugh pickle you do it

@sovdeeth sovdeeth closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants