Banner Patterns #7216
Banner Patterns #7216
Conversation
| patterns.add("[a] [new] " | ||
| + getKey(type) | ||
| + " [banner] pattern colo[u]red %*color%" |
There was a problem hiding this comment.
| patterns.add("[a] [new] " | |
| + getKey(type) | |
| + " [banner] pattern colo[u]red %*color%" | |
| patterns.add("[a] %*color%" | |
| + getKey(type) | |
| + " [banner] pattern" |
can use the old pattern for non-literals
| Object type = patternTypes[i]; | ||
| try { | ||
| patterns.add("[a] [new] " | ||
| + getKey(type) |
There was a problem hiding this comment.
why not just register a new type for the patterns?
There was a problem hiding this comment.
Do you think this would be better? I assumed having all this mess with reflection and stuff would be better to have in this class rather than in the BukkitClasses
There was a problem hiding this comment.
well i would make a banner module honestly
but yes it would be way better
There was a problem hiding this comment.
The only problem I see by adding the type, is that it may conflict with the banner patterns within skript-aliases. If the patterns I set within the lang consist of the words banner pattern such as creeper: creeper banner pattern
There was a problem hiding this comment.
That is true, so how should we or I approach this?
There was a problem hiding this comment.
well there's precedent here with stuff like chicken and a chicken
since you can do 1 of creeper banner pattern to avoid the ambiguity i'm willing to accept the breaking change
idk about the others' opinions.
There was a problem hiding this comment.
alternatively, we could get wacky and use unique names, like stamp instead of pattern, or something similarly different.
There was a problem hiding this comment.
Im down with whatever, what about creeper pattern type?
There was a problem hiding this comment.
I'm not a fan of just appending type to things, as it doesn't really mean much in general and is already confusing enough with enchantment vs enchantment type and same with potion effects. I'm in favor of as-is, with the breaking change, tbh.
Description
This PR aims to allow users to manipulate banner patterns on a banner
Note: Yes I do know the
banner patternexists within skript-aliases. However, it does not allow setting the color of the pattern.Target Minecraft Versions: any
Requirements: none
Related Issues: none