Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Change http to https #2060

Closed
wants to merge 1 commit into from
Closed

ENH: Change http to https #2060

wants to merge 1 commit into from

Conversation

Leengit
Copy link
Contributor

@Leengit Leengit commented Jun 19, 2024

Addresses runtime error messages like:

Mixed Content: The page at 'https://extensions.slicer.org/catalog/All/32752/linux' was loaded over HTTPS, but requested an insecure image 'http://www.slicer.org/slicerWiki/images/2/2b/SlicerIGTLogo.png'. This content should also be served over HTTPS.

This was accomplished with a simple string replacement. What is best practice for checking that this hasn't broken any links?

Addresses runtime error messages like:
    Mixed Content: The page at
    'https://extensions.slicer.org/catalog/All/32752/linux' was loaded
    over HTTPS, but requested an insecure image
    'http://www.slicer.org/slicerWiki/images/2/2b/SlicerIGTLogo.png'. This
    content should also be served over HTTPS.
@jcfr
Copy link
Member

jcfr commented Jun 19, 2024

Thanks for the pull request 🙏

Considering that:

  1. this pull request updates the archived extensions
  2. existing extensions have already been updated through the pull requests referenced in Meta issue referencing extension updates #2041
  3. re-build of Stable extensions to account for the updated extensions will be done tomorrow following the integration of bluestreak/overload: Move SlicerStable from "overload" to "bluestreak" DashboardScripts#70

... I am closing this pull request.

@jcfr jcfr closed this Jun 19, 2024
@Leengit Leengit deleted the https branch June 19, 2024 19:12
@Leengit
Copy link
Contributor Author

Leengit commented Jun 19, 2024

Thank you for the clarification and for closing this pull request.

I don't see an easy way to check whether the list at #2041 includes a pull request that amends the Slicer/ExtensionsIndex/README.md link to https://www.slicer.org/slicerWiki/images/a/ab/Extensions-Index-to-Catalog-cycle.png. If that's not updated ....

@jcfr
Copy link
Member

jcfr commented Jun 19, 2024

[...] a pull request that amends the Slicer/ExtensionsIndex/README.md

Thanks for the note, update of the README file has just been contributed into the following pull request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants