Fix Surface::lock_front_buffer failing when ffi::gbm_surface_lock_front_buffer succeeds #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt_buffer succeeds With the proprietary vivante driver it's been observed that gbm_surface_has_free_buffers() fails even though gbm_surface_lock_front_buffer() succeeds. Since C/C++ based programs like Weston, kmscube, mutter, or Qt's eglfs renderer don't check for has_free_buffers() before lock_front_buffer() and they work with said drivers, work around it by removing the check. Fixes Smithay#36
Drakulix
approved these changes
Mar 20, 2024
|
Thanks! |
tronical
deleted the
simon/vivante-no-free-buffer-check-before-lock-front-buffer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the proprietary vivante driver it's been observed that gbm_surface_has_free_buffers() fails even though
gbm_surface_lock_front_buffer() succeeds. Since C/C++ based programs like Weston, kmscube, mutter, or Qt's eglfs renderer don't check for has_free_buffers() before lock_front_buffer() and they work with said drivers, work around it by removing the check.
Fixes #36