Skip to content

Commit

Permalink
FIX: add return values to all addGraph()-Variants in JKQTPlotter (to …
Browse files Browse the repository at this point in the history
…mirror the interface of JKQTBasePlotter), fixes issue jkriege2#140
  • Loading branch information
jkriege2 authored and Snolandia committed Nov 22, 2024
1 parent fd985dc commit 1e0d996
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions doc/dox/whatsnew.dox
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,12 @@ Changes, compared to \ref page_whatsnew_V4_0_0 "v4.0.0" include:
<li>FIXED issue mentioned in <a href="https://github.com/jkriege2/JKQtPlotter/pull/110">#110: Lock the panning action to certain values: View zooms in, when panning close to AbosluteXY</a> (thanks to <a href="https://github.com/sim186">user:sim186</a> for reporting)</li>
<li>FIXED: jkqtpstatSum() and jkqtpstatSumSqr() did not work, as a non-existing function is called internally</li>
<li>FIXED removed unnecessary operators (<,>,<=,>=) from JKQTPColumnIterator and JKQTPColumnConstIterator, which lead to exceptions on some compilers (MSVC)</li>
<li>FIXED/IMPROVED issue <a href="https://github.com/jkriege2/JKQtPlotter/issu
<li>FIXED symmetry when zooming with JKQTBasePlotter::zoomIn() or JKQTBasePlotter::zoomOut() </li>--es/100">#100: Add option to disable resize delay feature by setting the delay to zero</a> (thanks to <a href="https://github.com/fpalazzolo">user:fpalazzolo</a> for reporting)</li>
<li>FIXED/IMPROVED issue <a href="https://github.com/jkriege2/JKQtPlotter/issues/100">#100: Add option to disable resize delay feature by setting the delay to zero</a> (thanks to <a href="https://github.com/fpalazzolo">user:fpalazzolo</a> for reporting)</li>
<li>FIXED symmetry when zooming with JKQTBasePlotter::zoomIn() or JKQTBasePlotter::zoomOut() </li>
<li>FIXED/NEW: placement of plot-title (was not centerd in its box, but glued to the bottom) by adding a plotstyle parameter JKQTBasePlotterStyle::plotLabelOffset</li>
<li>FIXED/REWORKED issue <a href="https://github.com/jkriege2/JKQtPlotter/issues/111">#111: Can't write to PDF files with JKQTPlotter::saveImage() when passing a filename ending in ".pdf"</a> (thanks to <a href="https://github.com/fpalazzolo">user:fpalazzolo</a> for reporting):<br/>While fixing this issue, the functions JKQTBasePlotter::saveImage() etc. gained a bool return value to indicate whether sacing was successful.</li>
<li>IMPROVED/FIXED outside space requirements for color bars. Text was sometime too close to the plot border.</li>
<li>FIXED issue <a href="https://github.com/jkriege2/JKQtPlotter/issues/140">#140: addGraph function return value</a> by adding return values to all addGraph()-Variants in JKQTPlotter (to mirror the interface of JKQTBasePlotter), (thanks to <a href="https://github.com/sajadblog">user:sajadblog</a></li>
<li>REWORKED JKQTBasePlotter::saveData() with a more consistent interface and a bool return value to indicate success or failure + improved documentation, added methods to JKQTPSaveDataAdapter that allow to specify file extensions and an ID for the plugin.</li>
<li>REWORKED: separation and gruping factor for barcharts on autoscaling</li>
<li>REORGANIZED: separated line-graphs from jkqtpscatter.h/.cpp into jkqtplines.h/.cpp</li>
Expand Down
4 changes: 2 additions & 2 deletions lib/jkqtplotter/jkqtplotter.h
Original file line number Diff line number Diff line change
Expand Up @@ -783,9 +783,9 @@ class JKQTPLOTTER_LIB_EXPORT JKQTPlotter: public QWidget {
/** \copydoc JKQTBasePlotter::addGraph() */
inline size_t addGraph(JKQTPPlotElement* gr) { return plotter->addGraph(gr); }
/** \copydoc JKQTBasePlotter::addGraphOnTop() */
inline void addGraphOnTop(JKQTPPlotElement* gr) { plotter->addGraphOnTop(gr); }
inline size_t addGraphOnTop(JKQTPPlotElement* gr) { return plotter->addGraphOnTop(gr); }
/** \copydoc JKQTBasePlotter::addGraphAtBottom() */
inline void addGraphAtBottom(JKQTPPlotElement* gr) { plotter->addGraphAtBottom(gr); }
inline size_t addGraphAtBottom(JKQTPPlotElement* gr) { return plotter->addGraphAtBottom(gr); }

/** \copydoc JKQTBasePlotter::moveGraphTop() */
inline void moveGraphTop(JKQTPPlotElement* gr) { plotter->moveGraphTop(gr); }
Expand Down

0 comments on commit 1e0d996

Please sign in to comment.