Skip to content

Commit

Permalink
Merge pull request #128 from RonnChyran/disposable-plugin
Browse files Browse the repository at this point in the history
Plugin: Make IBasePlugin inherit from IDisposable (Fixes #127)
  • Loading branch information
chyyran committed Jul 19, 2015
2 parents bc2ca02 + 856c735 commit 94c0e0c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Snowflake.API/Plugin/IBasePlugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
using System.Reflection;
using Snowflake.Service;
using System.IO;
using System;
namespace Snowflake.Plugin
{
/// <summary>
/// The common interface between all plugins.
/// Only classes that are derived from IBasePlugin will be imported
/// </summary>
public interface IBasePlugin
public interface IBasePlugin : IDisposable
{
/// <summary>
/// The name of the plugin
Expand Down Expand Up @@ -52,6 +53,6 @@ public interface IBasePlugin
/// The IPluginConfiguration configuration associated with this plugin.
/// This is null unless it has been initialized by the plugin.
/// </summary>
IPluginConfiguration PluginConfiguration { get; }
IPluginConfiguration PluginConfiguration { get; }
}
}
5 changes: 5 additions & 0 deletions Snowflake/Plugin/BasePlugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,10 @@ public string GetStringResource(string resourceName)
return file;
}
}

public virtual void Dispose()
{

}
}
}

0 comments on commit 94c0e0c

Please sign in to comment.