refactor out double call to self.player

Snowiiii · Aug 21, 2024 · e34fc47 · e34fc47
1 parent dda2958
commit e34fc47
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pumpkin/src/client/player_packet.rs b/pumpkin/src/client/player_packet.rs
@@ -400,11 +400,12 @@ impl Client {
     }
 
     pub fn handle_set_creative_slot(&mut self, _server: &mut Server, packet: SSetCreativeSlot) {
-        let gamemode = self.player.as_ref().unwrap().gamemode;
-        if gamemode != GameMode::Creative {
-            self.kick("Invalid action, you can only do that if you are in creative")
+        let player = self.player.as_mut().unwrap();
+        if player.gamemode != GameMode::Creative {
+            self.kick("Invalid action, you can only do that if you are in creative");
+            return;
         }
-        let inventory = &mut self.player.as_mut().unwrap().inventory;
+        let inventory = &mut player.inventory;
 
         inventory.set_slot(packet.slot as usize, packet.clicked_item.to_item(), false);
     }