Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use derive macro for Default trait on Scoreboard struct #208

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

suprohub
Copy link
Contributor

Description

A Detailed Description:
when I was reading the code I accidentally came across this:

impl Default for Scoreboard {
    fn default() -> Self {
        Self::new()
    }
}

In my opinion, this is a useless piece of code, because we can use #[derive(Default)] instead of this, for speed up
code read time.

Testing

cargo run and joining to server

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings cargo clippy

@Snowiiii
Copy link
Owner

Looks good.
Thanks @suprohub

@Snowiiii Snowiiii merged commit ba6f50a into Snowiiii:master Oct 28, 2024
21 checks passed
@suprohub suprohub deleted the use-macro branch October 29, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants