small CChunkData write improvement #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| palette.iter().enumerate().for_each(|(i, id)| { | ||
| palette_map.insert(*id, i); | ||
|
|
||
| let mut palette_ids = Vec::with_capacity(palette.len()); |
There was a problem hiding this comment.
You could probably improve this by removing this Vec and using a lazy iterator instead. This vec seems to only be used for an iterator.
There was a problem hiding this comment.
Good idea, reusing the palette Vec works the same. No need to have the palette_ids Vec
BenjaminBrienen
approved these changes
Oct 30, 2024
|
I tested the changes on pre-generated worlds and our own Chunk gen and can confirm that everything works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though Vec has a worse time complexity for this, the HashMap overhead is worse for performance
Testing
Performance profiling was done using cargo-flamegraph.
If this breaks something I'll be genuinely surprised.
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmtcargo clippy