Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic chat message packet #45

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

kralverde
Copy link
Contributor

Fixes basic chat message packets.

@Snowiiii
Copy link
Owner

Hey, Im sure what was the problem?, Was it that is use 255 bytes instead of 256 ?

@kralverde
Copy link
Contributor Author

kralverde commented Aug 21, 2024

it looks like the 256 OBO. Additionally some optional types do not have a boolean in-front of them; they are conditional on other things. Namely the previous signatures (based off IDK) and bitset (based off the filter type). Those cannot use the default serialization since it appends a boolean before the value.

@Snowiiii
Copy link
Owner

So, It generally works now?

@kralverde
Copy link
Contributor Author

For normal chat messages, yes

@Snowiiii
Copy link
Owner

Thanks so much. I really see the effort you put into this. Good job 👍

@Snowiiii Snowiiii merged commit b0df1a7 into Snowiiii:master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants