Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of individual packages #47

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

Luk-ESC
Copy link
Contributor

@Luk-ESC Luk-ESC commented Aug 21, 2024

Previously pumpkin-text, pumpkin-protocol and pumpkin-world would not compile on their own.
This happened because we didn't specify the required features, but since a dependency (or pumpkin) enabled them, the error went unnoticed.
Check out https://doc.rust-lang.org/cargo/reference/features.html#feature-unification for more information.

This PR enables the sync feature for tokio which is required by pumpkin-world and moves uuid to the workspace so that every crate uses the same feature set (specifically, pumpkin-text and pumpkin-protocol also require it's serde feature).

@Snowiiii
Copy link
Owner

Hey, Your right and i have nothing to add. Thanks for the PR @Luk-ESC 👍

@Snowiiii Snowiiii merged commit 59a4fe5 into Snowiiii:master Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants