Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

location eq added #533

Merged
merged 2 commits into from
Oct 16, 2023
Merged

location eq added #533

merged 2 commits into from
Oct 16, 2023

Conversation

KirylAkulich1
Copy link
Contributor

Description

add IEquatable interface for location

Added:

  • IEquatable interface for location

  • Core (all platforms)

  • iOS

  • Android

PR Checklist

  • [x ] I have read the CONTRIBUTING document
  • [x ] My code follows the code styles
  • [x ] Targets the correct branch
  • [x ] Tests are passing (or failures are unrelated)

@github-actions github-actions bot added the c/wl Related to WhiteLabel component. label Oct 16, 2023
TimofeyBurak
TimofeyBurak requested changes Oct 16, 2023
View reviewed changes
Softeq.XToolkit.WhiteLabel/Location/LocationModel.cs Outdated
return true;
}

return other is LocationModel model &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this check is always true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@KirylAkulich1 KirylAkulich1 merged commit 33d8920 into project/PH1 Oct 16, 2023
3 checks passed
@wcoder wcoder mentioned this pull request Oct 25, 2023
Merged
4 tasks
@pavel-leonenko pavel-leonenko deleted the feature/add-equatable-interface-for-location branch March 27, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimofeyBurak TimofeyBurak TimofeyBurak approved these changes

Assignees
No one assigned
Labels
c/wl Related to WhiteLabel component.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KirylAkulich1 @TimofeyBurak