add logs #556
Merged
add logs #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c/common
| { | ||
| var importParams = new NSAttributedStringDocumentAttributes | ||
| { | ||
| DocumentType = NSDocumentType.HTML, | ||
| StringEncoding = encoding | ||
| }; | ||
|
|
||
| var error = new NSError(); | ||
| NSError error = new NSError(); |
There was a problem hiding this comment.
Is it needed to replace var?
| catch (Exception ex) | ||
| { | ||
| logger?.Error(ex); | ||
| logger?.Info("Error message: " + error.Description); |
There was a problem hiding this comment.
Is it possible that there will be no exception but error is not empty?
And is it possible that error == null here?
pavel-leonenko
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist