Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rule S2159: Add Dart language #4153

Merged

Conversation

antonioaversa
Copy link
Contributor

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@antonioaversa antonioaversa changed the title Modify S2159 rule: Add Dart language Modify rule S2159: Add Dart language Aug 15, 2024
@antonioaversa antonioaversa marked this pull request as ready for review August 15, 2024 12:21
@@ -1,5 +1,5 @@
{
"title": "Silly equality checks should not be made",
"title": "Unnecessary equality checks should not be made",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@antonioaversa antonioaversa merged commit b0ec321 into master Aug 15, 2024
13 of 14 checks passed
@antonioaversa antonioaversa deleted the Antonio/dart-88-s2159-unrelated_type_equality_checks branch August 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants