Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S5147(C#): NoSQL operations should not be vulnerable to injection attacks APPSEC-2024 #4165

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@loris-s-sonarsource loris-s-sonarsource changed the title Create rule S5147 Create rule S5147(C#): NoSQL operations should not be vulnerable to injection attacks Aug 20, 2024
@loris-s-sonarsource loris-s-sonarsource changed the title Create rule S5147(C#): NoSQL operations should not be vulnerable to injection attacks Create rule S5147(C#): NoSQL operations should not be vulnerable to injection attacks APPSEC-2024 Aug 20, 2024
@loris-s-sonarsource loris-s-sonarsource marked this pull request as ready for review August 20, 2024 16:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things to do, see the comments.

I don't think the "Why is this an issue?" and "What is the potential impact?" sections are great contentwise, but since it is unrelated to this PR, I don't think there is an urgent need to improve it now.

Co-authored-by: Hendrik Buchwald <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small detail, otherwise LGTM

rules/S5147/common/fix/builder-pattern.adoc Outdated Show resolved Hide resolved
@loris-s-sonarsource loris-s-sonarsource enabled auto-merge (squash) August 23, 2024 12:06
Copy link

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@loris-s-sonarsource loris-s-sonarsource merged commit 504835d into master Aug 23, 2024
9 of 12 checks passed
@loris-s-sonarsource loris-s-sonarsource deleted the rule/S5147-add-csharp branch August 23, 2024 12:10
Copy link

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants