Fixes and refactoring #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: componentize mentor services
refactor: componentize testimony services
refactor: componetize User services
refactor: import services on module files
refactor: added missing descriptions
|
PatrickOtero
requested review from
rigonlucas,
EddieSCJ and
JoaoPauloAmendolaDev
rigonlucas
approved these changes
Jan 31, 2024
| constructor(private userRepository: UserRepository) {} | ||
|
|
||
| async execute(): Promise<UserEntity[]> { | ||
| return this.userRepository.findAllUsers(); |
There was a problem hiding this comment.
Deveriam sim, mas ainda não apliquei. Vou tentar fazer amanhã à tarde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
1- Now testimonies updates when mentors data updates.
2 - Some missing swagger endpoints descriptions were added.
3 - Moved "templates" folder inside mail module folder (trying to fix the empty body email bug)
Refactors: The service files that were with all its services (functions) inside them now were divided into individual service files with only one service(function) inside.