Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons added for every visualizers and for mainLanding page #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rajan-poudel
Copy link

@rajan-poudel rajan-poudel commented Jun 18, 2024

Hey @Soumya-Kushwaha , I have added icons for all four visualizers and for mainLanding page as well. Along that, I have followed PR guidelines as well. If I have done any mistakes , please let me know :)

Closes #104

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @rajan-poudel! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest resolving conflicts before moving ahead

Copy link
Collaborator

@jessicachawla jessicachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve conflicts

@rajan-poudel
Copy link
Author

@dinxsh & @jessicachawla Could you explain me what's the wrong in the code? I am a newbie to open source contribution so :)
I have edited only one line in five files (mainLanding.py, Intensity-vs-Frequency-and-time.py, Spectogram.py, Amplitude-Frequency-Visualizer.py & Waveform.py). And the change i did was:

image

Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a couple changes you'll be required fix these conflicts just dm me on discord @ dinxsh and ill guide you personally through it :)

@rajan-poudel
Copy link
Author

Thank you so much @dinxsh :)

This was referenced Jun 22, 2024
Copy link
Collaborator

@dinxsh dinxsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding catchy Icons for different visualizers
4 participants