Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPRIND-14 #115

Merged
merged 13 commits into from
Jun 27, 2024
Merged

SPRIND-14 #115

merged 13 commits into from
Jun 27, 2024

Conversation

sksadjad
Copy link
Contributor

added x5c support and made sure that we support request-responses without dids

nklomp
nklomp requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions on removed tests

packages/client/lib/__tests__/IT.spec.ts Show resolved Hide resolved
packages/client/lib/__tests__/IT.spec.ts Show resolved Hide resolved
nklomp
nklomp reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remark about code outside of the v11 builder doing a check, that probably the v11 builder should do itself

packages/client/lib/CredentialRequestClientBuilder.ts Show resolved Hide resolved
@nklomp nklomp merged commit e6034f5 into develop Jun 27, 2024
2 checks passed
@nklomp nklomp deleted the feature/SPRIND-14 branch June 27, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nklomp nklomp nklomp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sksadjad @nklomp