Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/jarm_sdk #158

Merged
merged 86 commits into from
Oct 21, 2024

chore: PR feedback (partly)

0603b43
Select commit
Loading
Failed to load commit list.
Merged

feature/jarm_sdk #158

chore: PR feedback (partly)
0603b43
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 10, 2024 in 0s

48.81% (-40.42%) compared to 56b16a3

View this Pull Request on Codecov

48.81% (-40.42%) compared to 56b16a3

Details

Codecov Report

Attention: Patch coverage is 7.69231% with 12 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (56b16a3) to head (0603b43).
Report is 810 commits behind head on develop.

Files with missing lines Patch % Lines
packages/client/lib/OpenID4VCIClientV1_0_13.ts 10.00% 9 Missing ⚠️
packages/did-auth-siop-adapter/lib/did/DidJWT.ts 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (56b16a3) and HEAD (0603b43). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (56b16a3) HEAD (0603b43)
6 0
unittest 6 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #158       +/-   ##
============================================
- Coverage    89.22%   48.81%   -40.42%     
============================================
  Files           17       74       +57     
  Lines          668     5005     +4337     
  Branches       170     1787     +1617     
============================================
+ Hits           596     2443     +1847     
- Misses          69     2560     +2491     
+ Partials         3        2        -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.