-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: offer creation improvements #159
fix: offer creation improvements #159
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #159 +/- ##
============================================
- Coverage 89.22% 49.10% -40.12%
============================================
Files 17 74 +57
Lines 668 4975 +4307
Branches 170 1730 +1560
============================================
+ Hits 596 2443 +1847
- Misses 69 2529 +2460
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hey @nklomp do you have a chance to look at this PR this week? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We always use accolades to prevent bugs in case someone had a rough night ;)
} | ||
} | ||
return { credential_offer, credential_offer_uri, scheme, baseUri, grants: credential_offer.grants } | ||
if (grants) credential_offer.grants = grants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accolades
@TimoGlastra Small nudge, since you requested for these PRs to be merged |
Signed-off-by: Timo Glastra <[email protected]>
done |
Some improvements / cleanup to the credential offer creation process:
authorization_server
in e.g. the pre auth flow was removed when the offer was createdcredential_offer_uri
param, this was leading to weird behaviour where sometimes the value would be the whole uriopenid-credential-offer://credential_offer_uri=<uri>
and sometimes just<uri>
. So now the object just contains the uri that hosts the credential offer, not the uri that is scanned by the wallet (it's quite confusing that the credential offer uri can contain acredential_offer_uri
param, so it was somtimes interchanged).credential_offer_uri
param (Fixescredential_offer_uri=
hosted credential url should be uri encoded in the credential offer #102)