fix: handle non-exteral submission edge cases #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Glastra <[email protected]>
nklomp
requested changes
Aug 20, 2024
| message: `VP format ${vp.format} is not supported`, | ||
| }); | ||
| continue; | ||
| // TODO: check that not longer than 0 |
There was a problem hiding this comment.
Suggest to add it immediately. It is easy to implement and would prevent a implementer from making mistakes that are hard to track down
There was a problem hiding this comment.
Yes sorry that is sloppy of me, meant to do that before opening the PR. will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered some issues when integrating the multi-vp support into the OID4VP library.
Mainly it didn't handle correctly when non-external presentation submissions were used, and the submission thus didn't use nested paths. We now handle this based on the presentationSubmissionLocation.
Also added some tests covering these cases