-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/SDK-34_multi-vp-fixes #172
Conversation
# Conflicts: # lib/signing/types.ts # package.json
…ect path for information
…e/PEX into feature/nb-pd # Conflicts: # pnpm-lock.yaml
…g mode. It was included only since RN did not have a proper matchAll function some time ago.
…ture/multi-vp-fixes # Conflicts: # package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remarks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See remark about new logic for credentials per presentation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #172 +/- ##
===========================================
- Coverage 93.32% 92.81% -0.51%
===========================================
Files 66 66
Lines 2666 2715 +49
Branches 675 635 -40
===========================================
+ Hits 2488 2520 +32
- Misses 173 194 +21
+ Partials 5 1 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Other information: