Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SDK-34_multi-vp-fixes #172

Merged
merged 53 commits into from
Oct 9, 2024
Merged

Conversation

sanderPostma
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Other information:

sanderPostma and others added 30 commits September 18, 2024 12:55
# Conflicts:
#	lib/signing/types.ts
#	package.json
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remarks.

.github/workflows/main.yml Outdated Show resolved Hide resolved
lib/PEX.ts Show resolved Hide resolved
lib/PEX.ts Outdated Show resolved Hide resolved
lib/PEX.ts Outdated Show resolved Hide resolved
lib/PEXv2.ts Outdated Show resolved Hide resolved
lib/evaluation/evaluationClientWrapper.ts Outdated Show resolved Hide resolved
lib/evaluation/evaluationClientWrapper.ts Outdated Show resolved Hide resolved
lib/evaluation/evaluationClientWrapper.ts Outdated Show resolved Hide resolved
lib/evaluation/evaluationClientWrapper.ts Show resolved Hide resolved
Copy link
Contributor

@nklomp nklomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remark about new logic for credentials per presentation

lib/PEX.ts Show resolved Hide resolved
@nklomp nklomp merged commit 64ac85e into develop Oct 9, 2024
2 checks passed
@nklomp nklomp deleted the feature/SDK-34_multi-vp-fixes branch October 9, 2024 19:55
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 79.08497% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.81%. Comparing base (ca2387e) to head (dd98f31).
Report is 54 commits behind head on develop.

Files with missing lines Patch % Lines
lib/evaluation/evaluationClientWrapper.ts 62.50% 18 Missing ⚠️
lib/PEX.ts 84.88% 13 Missing ⚠️
...ation/handlers/limitDisclosureEvaluationHandler.ts 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #172      +/-   ##
===========================================
- Coverage    93.32%   92.81%   -0.51%     
===========================================
  Files           66       66              
  Lines         2666     2715      +49     
  Branches       675      635      -40     
===========================================
+ Hits          2488     2520      +32     
- Misses         173      194      +21     
+ Partials         5        1       -4     
Flag Coverage Δ
unittest 92.81% <79.08%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants