Feature/sdk 44 #276
Draft
Feature/sdk 44 #276
+116
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderPostma
requested changes
Nov 14, 2024
| } catch (error) { | ||
| throw Error(`Could not initialize the federation client: ${error.message}`) | ||
|
|
||
| return await response.text() |
There was a problem hiding this comment.
What are we doing with the HTTP status >= 300? response.text() may return an error message or a blank string.
There was a problem hiding this comment.
I added a check to throw if status is not 200.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.