Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create timestep embedding tensor on device #375

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drhead
Copy link

@drhead drhead commented May 17, 2024

The timestep embed function currently creates a tensor on cpu and then moves it to GPU which causes a forced device sync every forward pass. This creates it directly on device, which avoids the issue and stops it from blocking dispatch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant