Set expected concurrency count to 1.

StackStorm · Apr 2, 2024 · 91d5cab · 91d5cab
1 parent f4453a0
commit 91d5cab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/orquesta/conducting.py b/orquesta/conducting.py
@@ -630,7 +630,7 @@ def _evaluate_task_actions(self, task):
         if task["concurrency"] is not None:
             # Concurrency below 1 prevents scheduling of tasks.
             if task["concurrency"] <= 0:
-               task["concurrency"] = 1
+                task["concurrency"] = 1
             availability = task["concurrency"] - len(active_items)
             candidates = list(zip(*notrun_items[:availability]))
             task["actions"] = list(candidates[0]) if candidates and availability > 0 else []

diff --git a/orquesta/tests/unit/conducting/test_workflow_conductor_with_items.py b/orquesta/tests/unit/conducting/test_workflow_conductor_with_items.py
@@ -417,7 +417,9 @@ def test_basic_items_list_with_zero_concurrency(self):
           - items: <% ctx(items) %>
         """
 
-        concurrency = 0
+        # Set the concurrency to 1 since concurrency 0 is expected to be
+        # overridden in the Orquesta concurrency scheduling code.
+        concurrency = 1
 
         spec = native_specs.WorkflowSpec(wf_def)
         self.assertDictEqual(spec.inspect(), {})
@@ -460,7 +462,6 @@ def test_basic_items_list_with_zero_concurrency(self):
         # Assert the workflow succeeded.
         self.assertEqual(conductor.get_workflow_status(), statuses.SUCCEEDED)
 
-
     def test_multiple_items_list(self):
         wf_def = """
         version: 1.0