Switch to using nginx puppet resources to manage the stackstorm nginx config #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmaludy
force-pushed
the
feature/nginx-config
branch
from
8377b61
to
e77cf04
Compare
arm4b
approved these changes
Aug 17, 2020
There was a problem hiding this comment.
👍
But I generally dislike the Puppet granular approach trying to manage every single field. If upstream st2 nginx config is changed, - things will need a dedicated sync-up every time.
This is good as far someone manages it. So thanks for that work @nmaludy!
|
This PR also reminds me we'll need a follow-up on StackStorm/community#44 |
bishopbm1
pushed a commit
to EncoreTechnologies/puppet-st2
that referenced
this pull request
May 20, 2022
Switch to using nginx puppet resources to manage the stackstorm nginx config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #262
This changes the way Puppet manages the StackStorm nginx config from basically just copying the file shipped with the RPM/DEB packages, over to Puppe native nginx resources.
The end result her is that the management of the nginx config is not idempotent (it was not before). It also allows us to do things like tweak the SSL settings (protocols, ciphers, etc) used by nginx to create a security hardened setup.