-
-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass without exception if jinja parameter isn't found #6101
base: master
Are you sure you want to change the base?
Conversation
49280d1
to
9f8c861
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could:
- collect a list of nodes (vars) that aren't valid as template vars
- if ANY of the vars DO exist, throw an error for the missing nodes.
- if NONE of the vars exist, then assume it is a string and ignore.
Otherwise, I'm concerned this could hide misspellings.
I don't understand:
|
Most, if not all, my actions already have a jinja template parameter for {{config_context.var}}. So I don't think check if ALL are parameters would work in my case. We have a lot of log files with One can always just utilize a parameter in their python script. |
I'd rather see a more deterministic method to processing (or not) template strings. For example, adding a new input data type |
fix tests so they do not check for exception for rendering parameters remove debugging and clean up comments remove comments in params rendering code black fixes st2common tests remove unused var
e795566
to
9f46039
Compare
does not raise and error any more
It would be nice to get this merged in. We have a lot of logs with |
If a jinja parameter doesn't exist as an input parameter then do not throw an exception and leave the value as a string parameter.
We have some input paramters like:
These cause stackstorm to attempt to resolve
some_text_here
as a variable since it has matching {{ and }}.This pr would allow those through as normal strings if they cannot be resolved.