Run more tests via Pants + pytest #6202

Lockfile diff: lockfiles/pants-plugins.lock [pants-plugins] == Upgraded dependencies == pantsbuild-pants 2.22.0 --> 2.23.0a0 pantsbuild-pants-testutil 2.22.0 --> 2.23.0a0 pex 2.3.1 --> 2.16.2 typing-extensions 4.3.0 --> 4.12.2 == Added dependencies == libcst 1.4.0

It is now a per-resolve option: [export].py_non_hermetic_scripts_in_resolve = ["st2"]

First, add metadata so pants can load the packs base path fixtures from st2common/resources for the content laoder tests. Second, add a fixture.py file in each base path, similar to the fixtures we have in st2tests, so that pants dependency inferrence can see where these fixtures are used. Third, the fixture file ended up creating a __pycache__ directory in the packs base paths which made tests fail due to an unexpected extra "pack" named "__pycache__". So, I excluded that as a valid pack name.

First, add metadata so pants can load the conf fixture from st2common/tests/resources for the logger test. Second, add a fixture.py file, similar to the fixtures we have in st2tests, so that pants dependency inferrence can see where these fixtures are used.

First, add metadata so pants can load the loadableplugin fixture from st2common/tests/resources for the plugin loader test. Second, add a fixture.py file, similar to the fixtures we have in st2tests, so that pants dependency inferrence can see where these fixtures are used.

Once pants can build our packages, all of the dist_utils bits should be deleted.

…pendency metadata

…code

Various tests were relying on the side effects of tests that nosetest runs before they ran. These include: - 3 in test_action_alias_utils.py::TestInjectImmutableParameters - 2 in test_jinja_render_data_filters.py - 1 in test_logging_middleware.py - 9 in test_operators.py::SearchOperatorTest - 3 in test_util_payload.py In particular, the oslo config initialization from the tests in st2common/tests/unit/services/ happens before these test ran, obscuring their dependence on this initialization. Pants runs each test file separately for fine-grained caching.

This looks like copy pasta as some of these files have a comment saying that running this before importing something else is required. However, by importing st2tests, that already implicitly happens in st2tests/st2tests/base.py. Then tests_config.parse_args() gets called again in the class init. Plus, I reviewed all the other imports, and none of them have import time side effects that matter for oslo config bits. So, these calls are not necessary, and the comments about them are wrong.

pants runs each test file separately. test_workflow_rerun only worked under nosetest because earlier files already did the monkey_patch. Without this, running this file in isolation, with either nosetest or pytest, hangs.

This way we do not need to patch the conf files in so many places.

all are passing locally now

…/unit/policies

These are not test files: - st2actions/tests/unit/test_async_runner.py - st2actions/tests/unit/test_polling_async_runner.py It looks like they were copied to st2tests/st2tests/mocks/runners/ at some point. Nothing imports from or uses the copies in st2actions, so just delete them.

…ffects importing anything form st2tests already handles running st2tests.config.parse_args() on import before loading the files from st2common that need those side effects. So, rely on that, and on the db test case base classes for running parse_args() where appropriate. The import side-effects are unfortunate, but this reduces how many places are making those changes.

…fects importing anything form st2tests already handles running st2tests.config.parse_args() on import before loading the files from st2common that need those side effects. So, rely on that, and on the db test case base classes for running parse_args() where appropriate. The import side-effects are unfortunate, but this reduces how many places are making those changes.

Actually there are no unit tests in st2tests/, so this just ensures no one will add one without pants running it.

Now pack_metadata targets will generate pack_content_resource instead of just resource. pack_content_resource is still a resource, but this setup allows us to find the generated resource targets more simply. This also harmonizes the implementation of pack_metadata to follow the fields definition of resources (esp moving dependencies into moved_fields instead of core_fields).

…esource targets This will allow rules to look up just action and sensor metadata (for example).

… module mapping Only handles the actual action/sensor python files. It does not yet handle: - <pack>/lib - <pack>/actions/lib

…thon module mapping This makes dependency inference aware of these which may be on the PYTHONPATH. - <pack>/lib - <pack>/actions/lib

The pack_metadata plugin now handles identifying these imports for dep inference. Next step, modify the PYTHONPATH as well.

The pack_metadata plugin now handles identifying these imports for dep inference, so there are more opportunities for the core pack to be imported ambiguously thanks to its symlink in st2tests/st2tests/fixtures/packs

…ython_content_rules

…ck_content

…sses

…_content and related rules

…TRA_SYS_PATH for tests This won't work until pants gets support for injecting path entries.

…ed field

…pants reqs

…xture Writes various test scenarios in the test sandbox. This should avoid repeating the setup in every test.

And fix the identified issues.

…ules And fix the identified mistake in conftest.

…_dependencies rule

…ack_tests rule

…ests

I do not know why this worked before. Perhaps it relied on quirks from old versions of /bin/sh. Without this fix the action chain test test_chain_pause_resume_with_error fails.

The symlink is not registered in pants. So far, this is the first time something has tried to access that file. So, just use the actual file instead of the symlink

I could change fetch-depth, but that would change it for both submodules and for the st2.git checkout.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run more tests via Pants + pytest #6202

Run more tests via Pants + pytest #6202

Commits on Sep 12, 2024

Run more tests via Pants + pytest #6202

Are you sure you want to change the base?

Run more tests via Pants + pytest #6202

Commits on Sep 12, 2024