Add ST2TESTS_SYSTEM_USER env var to set system_user.user in tests
#6242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we do not need to patch the conf files in so many places.
cognifloyd
requested review from
winem,
nzlosh,
mamercad,
rush-skills,
guzzijones,
amanda11 and
a team
pull-request-size
bot
added
the
size/M
amanda11
approved these changes
Sep 16, 2024
nzlosh
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new env var for tests:
ST2TESTS_SYSTEM_USER. When set, this will overridesystem_user.userin st2 conf so that you can run tests on systems that do not have thestanleyuser. When running tests locally, use the following to set system user to the current user:This follows the naming convention for test vars introduced in #5707 which introduced
ST2TESTS_PARALLEL_SLOT.These commits were extracted from my wip work in #6202.