Fix CUDA build #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliottslaughter
force-pushed
the
fix-cuda-build
branch
from
bc1cf33
to
4447765
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4.
__CUDACC__is not set in CPU source files, so we cannot rely on it. We cannot redefinedouble2is CUDA code when Legion is built withLegion_REDOP_COMPLEX. So instead we branch onUSE_CUDAto determine if we need to go down this path, and we rely on CUDA'sdouble2in all CUDA builds (both host and device code). In non-CUDA builds we define our own like we do today.Tested in both CUDA and non-CUDA builds.