Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish RobotInterface #15

Open
andreykurenkov opened this issue Dec 5, 2019 · 2 comments
Open

Finish RobotInterface #15

andreykurenkov opened this issue Dec 5, 2019 · 2 comments
Assignees
@rohun-kulkarni
Labels
enhancement New feature or request hygiene

Comments

@andreykurenkov
Copy link
Collaborator

What's up with all the commented out functions? Why don't we just use the one from perls?

perls2/perls2/robots/robot_interface.py

Line 80 in 6a52162

# @property

@andreykurenkov andreykurenkov added enhancement New feature or request hygiene labels Dec 5, 2019
@rohun-kulkarni
Copy link
Collaborator

It started as a crude todo list, but comments will be cleaned up. We need to decide which functions we want for all interface. A lot of the ones from perls were not used.

Robot interfaces are going through a redesign to have a consistent logic, so this definitely will be fixed with the next dev cycle.

@andreykurenkov
Copy link
Collaborator Author

Makes sense, I guess this issue is still useful then to track a TODO item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohun-kulkarni rohun-kulkarni

Labels
enhancement New feature or request hygiene
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andreykurenkov @rohun-kulkarni