[Enhancement] Optimize the root path choosing logic on tablet creation (backport #26238) #26382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
#26238) Fixes SR-18615 Returned a vector contains all the storage root paths and the vector is sorted by the disk usage in asc order, then the front portion of the vector excluding paths which have high disk usage is shuffled to avoid the newly created tablet is distributed on only on specific path. This is an enhancement to pr #20833, in the original logic, vector is sorted by available capacity in desc order and then shuffle half of the vector, this has two problems: 1. different disk may have different total capacity, we should sort the path based on usage not the available bytes. 2. if the disk usage of the root paths is similar, this will cause half of disks have have unbalanced number of tablet. Signed-off-by: Dejun Xia <[email protected]> (cherry picked from commit dbf5fc6) # Conflicts: # be/src/common/config.h
|
@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #26238 done by Mergify.
Cherry-pick of dbf5fc6 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com