[Feature] add function of date_diff in multi actions #26415

xuzifu666 · 2023-07-03T10:16:50Z

Fixes #23420

What type of PR is this:

Checklist:

I have added test cases for my bug fix or my new feature
This pr will affect users' behaviors
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

xuzifu666 · 2023-07-03T12:21:55Z

cc @silverbullet233 have a review plz

docs/sql-reference/sql-functions/date-time-functions/date_diff.md

need change

be/src/exprs/time_functions.cpp

silverbullet233 · 2023-07-04T03:08:36Z

test/sql/test_time_fn/T/test_time_fn

+select date_diff("2010-11-30 23:59:59", "2010-11-30 20:58:59", "hour");
+select date_diff("2010-11-30 23:59:59", "2010-11-30 20:58:59", "minute");
+select date_diff("2010-11-30 23:59:59", "2010-11-30 20:59:59", "second");
+


need more stronger test cases, such as parameters with more precision and some corner cases, such as SELECT date_diff('2020-03-01 00:00:05.000001','2020-03-02 00:00:05',day');

ok，had add more precision cases

silverbullet233 · 2023-07-05T07:41:47Z

be/src/exprs/time_functions.cpp

+        TimestampValue l = (TimestampValue)lv_column.value(row);
+        TimestampValue r = (TimestampValue)rv_column.value(row);


what if the value is NULL?

if the value is NULL，would return NULL

be/src/exprs/time_functions.cpp

silverbullet233 · 2023-07-05T07:45:14Z

test/sql/test_time_fn/T/test_time_fn

@@ -197,6 +197,29 @@ select dayofweek_iso("2023-01-03");
 select dayofweek_iso("");
 select dayofweek_iso(NULL);

+-- name: test_date_diff


plz add some test cases that the parameters contain NULL and the third paramter is not invalid

i had add testcase contained NULL，and if third paramter is valid would report a error like the picture:
mysql> select date_diff("2010-11-30 23:59:59", "2010-11-30 20:59:59", "aaa");
ERROR 1064 (HY000): Expr evaluate meet error: type column should be one of day/hour/minute/second/millisecond

i had add testcase contained NULL，and if third paramter is valid would report a error like the picture: mysql> select date_diff("2010-11-30 23:59:59", "2010-11-30 20:59:59", "aaa"); ERROR 1064 (HY000): Expr evaluate meet error: type column should be one of day/hour/minute/second/millisecond

should be added in test cases

get，had add this to testcases

murphyatwork · 2023-07-06T11:09:33Z

be/src/exprs/time_functions.cpp

+    }
+    ColumnPtr column = context->get_constant_column(2);
+    auto type_str = ColumnHelper::get_const_value<TYPE_VARCHAR>(column);
+    if (type_str != "day" && type_str != "hour" && type_str != "minute" && type_str != "second" &&


compare ignore case ?

Signed-off-by: xuzifu666 <[email protected]>

wanpengfei-git · 2023-07-06T14:04:20Z

[FE PR Coverage Check]

😍 pass : 0 / 0 (0%)

silverbullet233 · 2023-07-07T02:05:48Z

@mergify backport branch-3.0 branch-3.1

mergify · 2023-07-07T02:06:15Z

backport branch-3.0 branch-3.1

✅ Backports have been created

#26688 [Feature] add function of date_diff in multi actions (backport #26415) has been created for branch branch-3.0 but encountered conflicts
#26689 [Feature] add function of date_diff in multi actions (backport #26415) has been created for branch branch-3.1 but encountered conflicts

Fixes [#23420](#23420) (cherry picked from commit d372958) # Conflicts: # test/sql/test_time_fn/R/test_time_fn # test/sql/test_time_fn/T/test_time_fn

Fixes [#23420](#23420) (cherry picked from commit d372958) # Conflicts: # be/src/exprs/time_functions.cpp # test/sql/test_time_fn/R/test_time_fn # test/sql/test_time_fn/T/test_time_fn

Fixes [StarRocks#23420](StarRocks#23420) Signed-off-by: Zhuhe Fang <[email protected]>

Fixes [StarRocks#23420](StarRocks#23420)

Fixes [#23420](#23420) backport #26415

xuzifu666 requested a review from a team as a code owner July 3, 2023 10:16

mergify bot assigned xuzifu666 Jul 3, 2023

github-actions bot added the documentation Improvements or additions to documentation label Jul 3, 2023

xuzifu666 force-pushed the date_diff branch 2 times, most recently from 8a88b5d to e5a646e Compare July 3, 2023 12:15

xuzifu666 force-pushed the date_diff branch 3 times, most recently from cae0641 to 2ef2c47 Compare July 4, 2023 01:35

packy92 previously approved these changes Jul 4, 2023

View reviewed changes

docs/sql-reference/sql-functions/date-time-functions/date_diff.md Show resolved Hide resolved

packy92 reviewed Jul 4, 2023

View reviewed changes

docs/sql-reference/sql-functions/date-time-functions/date_diff.md Show resolved Hide resolved

silverbullet233 reviewed Jul 4, 2023

View reviewed changes

be/src/exprs/time_functions.cpp Show resolved Hide resolved

silverbullet233 reviewed Jul 4, 2023

View reviewed changes

xuzifu666 force-pushed the date_diff branch 5 times, most recently from 92cee60 to ff98036 Compare July 5, 2023 01:26

silverbullet233 reviewed Jul 5, 2023

View reviewed changes

be/src/exprs/time_functions.cpp Outdated Show resolved Hide resolved

silverbullet233 reviewed Jul 5, 2023

View reviewed changes

xuzifu666 force-pushed the date_diff branch 7 times, most recently from 2a6a0bf to ea00d17 Compare July 6, 2023 06:06

murphyatwork reviewed Jul 6, 2023

View reviewed changes

xuzifu666 added 8 commits July 6, 2023 19:51

refactor date_diff_time and add NULL testcase

aba93f2

Signed-off-by: xuzifu666 <[email protected]>

refactor date_diff_time and add NULL testcase

ebfcc84

Signed-off-by: xuzifu666 <[email protected]>

refactor date_diff_time and add NULL testcase

f7d0354

Signed-off-by: xuzifu666 <[email protected]>

add regex test case

e8b0c32

Signed-off-by: xuzifu666 <[email protected]>

add regex test case

9790cce

Signed-off-by: xuzifu666 <[email protected]>

clang style

52f67e1

Signed-off-by: xuzifu666 <[email protected]>

clang style

62e7fe1

Signed-off-by: xuzifu666 <[email protected]>

minor change

8c9bb1b

Signed-off-by: xuzifu666 <[email protected]>

xuzifu666 force-pushed the date_diff branch from a571f58 to 8c9bb1b Compare July 6, 2023 11:52

murphyatwork approved these changes Jul 6, 2023

View reviewed changes

silverbullet233 approved these changes Jul 6, 2023

View reviewed changes

murphyatwork enabled auto-merge (squash) July 6, 2023 14:05

packy92 approved these changes Jul 6, 2023

View reviewed changes

murphyatwork merged commit d372958 into StarRocks:main Jul 6, 2023
26 of 27 checks passed

This was referenced Jul 7, 2023

[Feature] add function of date_diff in multi actions (backport #26415) #26688

Closed

[Feature] add function of date_diff in multi actions (backport #26415) #26689

Closed

fzhedu pushed a commit to fzhedu/starrocks that referenced this pull request Jul 7, 2023

[Feature] add function of date_diff in multi actions (StarRocks#26415)

52a68c9

Fixes [StarRocks#23420](StarRocks#23420) Signed-off-by: Zhuhe Fang <[email protected]>

silverbullet233 pushed a commit to silverbullet233/starrocks that referenced this pull request Jul 11, 2023

[Feature] add function of date_diff in multi actions (StarRocks#26415)

3d7eed8

Fixes [StarRocks#23420](StarRocks#23420)

This was referenced Jul 11, 2023

[Feature] add function of date_diff in multi actions (#26415) #27002

Merged

[Feature] add function of date_diff in multi actions (#26415) #27003

Merged

silverbullet233 pushed a commit to silverbullet233/starrocks that referenced this pull request Jul 11, 2023

[Feature] add function of date_diff in multi actions (StarRocks#26415)

1d77e1a

Fixes [StarRocks#23420](StarRocks#23420)

silverbullet233 added a commit that referenced this pull request Jul 12, 2023

[Feature] add function of date_diff in multi actions (#26415) (#27003)

6b7e5b7

Fixes [#23420](#23420) backport #26415

silverbullet233 added a commit that referenced this pull request Jul 12, 2023

[Feature] add function of date_diff in multi actions (#26415) (#27002)

5a56d78

jaogoy requested a review from wangsimo0 September 19, 2023 14:16

jaogoy added the behavior_changed label Sep 19, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] add function of date_diff in multi actions #26415

[Feature] add function of date_diff in multi actions #26415

xuzifu666 commented Jul 3, 2023 •

edited by silverbullet233

Loading

xuzifu666 commented Jul 3, 2023

silverbullet233 Jul 4, 2023

xuzifu666 Jul 4, 2023 •

edited

Loading

silverbullet233 Jul 5, 2023

xuzifu666 Jul 5, 2023

silverbullet233 Jul 5, 2023

xuzifu666 Jul 5, 2023 •

edited

Loading

silverbullet233 Jul 5, 2023

xuzifu666 Jul 6, 2023

murphyatwork Jul 6, 2023

xuzifu666 Jul 6, 2023

wanpengfei-git commented Jul 6, 2023

silverbullet233 commented Jul 7, 2023

mergify bot commented Jul 7, 2023 •

edited

Loading

		TimestampValue l = (TimestampValue)lv_column.value(row);
		TimestampValue r = (TimestampValue)rv_column.value(row);

[Feature] add function of date_diff in multi actions #26415

[Feature] add function of date_diff in multi actions #26415

Conversation

xuzifu666 commented Jul 3, 2023 • edited by silverbullet233 Loading

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

xuzifu666 commented Jul 3, 2023

Choose a reason for hiding this comment

xuzifu666 Jul 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xuzifu666 Jul 5, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wanpengfei-git commented Jul 6, 2023

[FE PR Coverage Check]

silverbullet233 commented Jul 7, 2023

mergify bot commented Jul 7, 2023 • edited Loading

✅ Backports have been created

xuzifu666 commented Jul 3, 2023 •

edited by silverbullet233

Loading

xuzifu666 Jul 4, 2023 •

edited

Loading

xuzifu666 Jul 5, 2023 •

edited

Loading

mergify bot commented Jul 7, 2023 •

edited

Loading