[Enhancement] Support query dump for materialized view #26431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyehcf
previously approved these changes
Jul 4, 2023
fe/fe-core/src/main/java/com/starrocks/http/HttpServerHandler.java
Outdated
Show resolved
Hide resolved
murphyatwork
reviewed
Jul 4, 2023
| @@ -243,7 +243,9 @@ public static void analyze(InsertStmt insertStmt, ConnectContext session) { | |||
| insertStmt.setTargetTable(table); | |||
| insertStmt.setTargetPartitionIds(targetPartitionIds); | |||
| insertStmt.setTargetColumns(targetColumns); | |||
| session.getDumpInfo().addTable(database.getFullName(), table); | |||
| if (session.getDumpInfo() != null) { | |||
There was a problem hiding this comment.
why check this?
why not check this before ?
There was a problem hiding this comment.
Before queries always put the related tables/views/... into DumpInfo.
I've changed this to only save related infos when it's from HTTP query dump or enable_query_dump is true. I think this is more reasonable.
liuyehcf
previously approved these changes
Jul 5, 2023
LiShuMing
force-pushed
the
mv_query_dump
branch
3 times, most recently
from
fd9d1a0
to
07fef0f
Compare
Signed-off-by: Kevin Li <[email protected]>
Signed-off-by: Kevin Li <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
[FE PR Coverage Check]😍 pass : 107 / 127 (84.25%) file detail
|
murphyatwork
approved these changes
Jul 10, 2023
liuyehcf
approved these changes
Jul 10, 2023
|
@Mergifyio backport branch-3.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
To support query dump which query's table may contain mv, I did the changes: - Add "``" for output columns of Materialized View because mv's column may contain complex expressions (eg, `bitmap_union()`; - Only add dump info into QueryDumpInfo only when it's from HTTP query dump or `enable_query_dump` is true; - When adding mv into dump info, optimize the mv again because tables in query may be only a part of mv, and mv may contain other unique/foreign constraints in its properties. - Make the `tableMap ` in QueryDumpInfo ordered by the insert time because MV's replay needs the basic tables are created. - Mock some places to support MVs with external tables. To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. (cherry picked from commit 4f6a915) # Conflicts: # fe/fe-core/src/test/java/com/starrocks/analysis/ShowCreateViewStmtTest.java
silverbullet233
pushed a commit
to silverbullet233/starrocks
that referenced
this pull request
Jul 11, 2023
To support query dump which query's table may contain mv, I did the changes: - Add "``" for output columns of Materialized View because mv's column may contain complex expressions (eg, `bitmap_union()`; - Only add dump info into QueryDumpInfo only when it's from HTTP query dump or `enable_query_dump` is true; - When adding mv into dump info, optimize the mv again because tables in query may be only a part of mv, and mv may contain other unique/foreign constraints in its properties. - Make the `tableMap ` in QueryDumpInfo ordered by the insert time because MV's replay needs the basic tables are created. - Mock some places to support MVs with external tables. To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. Signed-off-by: silverbullet233 <[email protected]>
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Jul 13, 2023
To support query dump which query's table may contain mv, I did the changes: - Add "``" for output columns of Materialized View because mv's column may contain complex expressions (eg, `bitmap_union()`; - Only add dump info into QueryDumpInfo only when it's from HTTP query dump or `enable_query_dump` is true; - When adding mv into dump info, optimize the mv again because tables in query may be only a part of mv, and mv may contain other unique/foreign constraints in its properties. - Make the `tableMap ` in QueryDumpInfo ordered by the insert time because MV's replay needs the basic tables are created. - Mock some places to support MVs with external tables. To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include.
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Jul 13, 2023
To support query dump which query's table may contain mv, I did the changes: - Add "``" for output columns of Materialized View because mv's column may contain complex expressions (eg, `bitmap_union()`; - Only add dump info into QueryDumpInfo only when it's from HTTP query dump or `enable_query_dump` is true; - When adding mv into dump info, optimize the mv again because tables in query may be only a part of mv, and mv may contain other unique/foreign constraints in its properties. - Make the `tableMap ` in QueryDumpInfo ordered by the insert time because MV's replay needs the basic tables are created. - Mock some places to support MVs with external tables. To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. Signed-off-by: Kevin Li <[email protected]>
murphyatwork
pushed a commit
that referenced
this pull request
Jul 14, 2023
…) (#27154) To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include.
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Jul 25, 2023
…Rocks#26431) (StarRocks#27154) To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. Signed-off-by: Kevin Li <[email protected]>
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Jul 25, 2023
…Rocks#26431) (StarRocks#27154) To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. Signed-off-by: Kevin Li <[email protected]>
LiShuMing
added a commit
to LiShuMing/starrocks
that referenced
this pull request
Jul 25, 2023
…Rocks#26431) (StarRocks#27154) To support dump mv on mv queries, I added two invisible session variables: - query_excluding_mv_names indicates Query's candidate mvs should exculde. - query_including_mv_names indicates Query's candidate mvs should include. Signed-off-by: Kevin Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support query dump which query's table may contain mv, I did the changes:
bitmap_union();enable_query_dumpis true;tableMapin QueryDumpInfo ordered by the insert time because MV's replay needs the basic tables are created.To support dump mv on mv queries, I added two invisible session variables:
I added three cases:
What type of PR is this:
Checklist:
Bugfix cherry-pick branch check: