Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][Refactor] optimize array_contains_all/array_contains_seq function #51701

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Oct 10, 2024

Why I'm doing:

What I'm doing:

optimize the performance of array_contains_all and array_contains_seq, and reduce their implementation complexity from O(m*n) to O(m+n)

basic idea

  1. for array_contains_all, choose the side with less data to build a hash table to speed up the search
  2. for array_contains_seq, it is essentially similar to the string search algorithm. We can use the idea of ​​the KMP algorithm to speed up the search.

Test

Here I use two very simple queries to compare the performance

-- query 1
set @arr0 = array_generate(100000);
set @arr1 = array_generate(200000);
select array_contains_all(@arr1, @arr0);

-- query 2
set @arr0=array_append(array_repeat(1,100000),2);
set @arr1=array_append(array_repeat(1,50000),2);
select array_contains_seq(@arr0,@arr1);
baseline after optimization
query 1 1.66s 0.05s
query 2 1.08s 0.02s

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@silverbullet233 silverbullet233 requested review from a team as code owners October 10, 2024 06:55
@silverbullet233 silverbullet233 changed the title [WIP][Enhancement][Refactor] optimize array_contains_all/array_contains_seq function [Enhancement][Refactor] optimize array_contains_all/array_contains_seq function Oct 10, 2024
Seaven
Seaven previously approved these changes Oct 10, 2024
trueeyu
trueeyu previously approved these changes Oct 10, 2024
LiShuMing
LiShuMing previously approved these changes Oct 10, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Copy link

sonarcloud bot commented Oct 14, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 0 / 249 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/util/bit_mask.h 0 4 00.00% [36, 37, 40, 41]
🔵 be/src/exprs/array_functions.h 0 12 00.00% [158, 159, 162, 164, 167, 169, 179, 180, 183, 185, 188, 190]
🔵 be/src/exprs/array_functions.tpp 0 224 00.00% [1962, 1970, 1971, 1979, 1980, 1983, 1987, 1992, 1993, 1995, 1997, 2000, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2011, 2012, 2014, 2015, 2018, 2020, 2021, 2024, 2025, 2026, 2028, 2029, 2031, 2035, 2038, 2040, 2041, 2043, 2044, 2046, 2047, 2049, 2052, 2056, 2058, 2059, 2060, 2061, 2063, 2065, 2068, 2069, 2070, 2072, 2074, 2075, 2076, 2077, 2078, 2079, 2082, 2083, 2084, 2085, 2086, 2087, 2090, 2092, 2093, 2095, 2096, 2098, 2101, 2103, 2108, 2110, 2111, 2113, 2114, 2115, 2116, 2117, 2119, 2120, 2121, 2124, 2127, 2130, 2131, 2136, 2137, 2138, 2139, 2141, 2146, 2147, 2148, 2151, 2153, 2154, 2159, 2162, 2163, 2164, 2165, 2167, 2168, 2169, 2170, 2171, 2174, 2175, 2177, 2179, 2182, 2185, 2186, 2187, 2190, 2193, 2196, 2198, 2201, 2202, 2203, 2205, 2206, 2207, 2208, 2209, 2211, 2212, 2213, 2215, 2216, 2218, 2219, 2225, 2230, 2233, 2236, 2237, 2238, 2240, 2241, 2242, 2244, 2246, 2247, 2248, 2250, 2252, 2253, 2256, 2257, 2259, 2267, 2270, 2271, 2276, 2278, 2279, 2280, 2282, 2284, 2285, 2286, 2288, 2291, 2292, 2294, 2295, 2297, 2298, 2299, 2302, 2304, 2305, 2306, 2307, 2308, 2312, 2313, 2314, 2315, 2316, 2320, 2321, 2322, 2323, 2324, 2326, 2328, 2329, 2330, 2331, 2333, 2335, 2337, 2338, 2340, 2343, 2344, 2348, 2349, 2355, 2359, 2361, 2362, 2363, 2364, 2365, 2366, 2368, 2373, 2374, 2375, 2376, 2377, 2379, 2382, 2388, 2392, 2394, 2395]
🔵 be/src/column/column_helper.cpp 0 9 00.00% [439, 440, 441, 443, 444, 445, 446, 447, 448]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants