-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement][Refactor] optimize array_contains_all/array_contains_seq function #51701
Open
silverbullet233
wants to merge
6
commits into
StarRocks:main
Choose a base branch
from
silverbullet233:opt_array_has
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,024
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverbullet233
changed the title
[WIP][Enhancement][Refactor] optimize array_contains_all/array_contains_seq function
[Enhancement][Refactor] optimize array_contains_all/array_contains_seq function
Oct 10, 2024
Seaven
previously approved these changes
Oct 10, 2024
trueeyu
previously approved these changes
Oct 10, 2024
LiShuMing
previously approved these changes
Oct 10, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
dismissed stale reviews from LiShuMing, trueeyu, and Seaven
via
October 14, 2024 08:34
d45b86d
silverbullet233
force-pushed
the
opt_array_has
branch
from
October 14, 2024 08:34
ea2b6b2
to
d45b86d
Compare
Quality Gate passedIssues Measures |
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 0 / 249 (00.00%) file detail
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
optimize the performance of
array_contains_all
andarray_contains_seq
, and reduce their implementation complexity fromO(m*n)
toO(m+n)
basic idea
Test
Here I use two very simple queries to compare the performance
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: