Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind #51813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

decster
Copy link
Contributor

@decster decster commented Oct 11, 2024

Why I'm doing:

It's hard to debug TDE related issue, also there are ASAN memleaks in wren script engine

What I'm doing:

Add some util in script for TDE debug;
Add more info in segment load error log;
Fix memleak in wrenbind

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@decster decster changed the title [Enhancement] Add some util in script for TDE debug [Enhancement] Add some util in script for TDE debug; Fix memleak in wrenbind Oct 14, 2024
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[BE Incremental Coverage Report]

fail : 20 / 32 (62.50%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/rowset/rowset.cpp 0 5 00.00% [182, 183, 184, 185, 187]
🔵 be/src/storage/lake/rowset.cpp 5 10 50.00% [429, 430, 474, 491, 493]
🔵 be/src/script/script.cpp 15 17 88.24% [301, 302]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant