Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix dataCacheInfo leak in idToDataCacheInfo #51830

Merged
merged 1 commit into from
Oct 14, 2024
Merged

[BugFix] fix dataCacheInfo leak in idToDataCacheInfo #51830

merged 1 commit into from
Oct 14, 2024
+92 −1

Conversation

kevincai
Copy link
Contributor

@kevincai kevincai commented Oct 12, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kevincai kevincai requested review from a team as code owners October 12, 2024 03:48
@kevincai kevincai changed the title [BugFix] fix broken symmetric access to partitionInfo data members [BugFix] fix broken symmetric access to partitionInfo properties Oct 12, 2024
@kevincai kevincai force-pushed the fix-datacache-property branch 4 times, most recently from 505527d to 790266d Compare October 12, 2024 08:30
@kevincai kevincai requested a review from a team as a code owner October 12, 2024 13:30
@kevincai kevincai marked this pull request as draft October 13, 2024 01:41
@kevincai kevincai marked this pull request as ready for review October 13, 2024 10:36
@kevincai kevincai removed request for a team October 13, 2024 10:36
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 13, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kevincai kevincai changed the title [BugFix] fix broken symmetric access to partitionInfo properties [BugFix] fix dataCacheInfo leak in idToDataCacheInfo Oct 13, 2024
@kevincai
Copy link
Contributor Author

only fix.issue.in this pr, refactor related code will be submit in separate pr

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 5 / 5 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/catalog/PartitionInfo.java 5 5 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb enabled auto-merge (squash) October 14, 2024 01:13
@wyb wyb merged commit 688714e into StarRocks:main Oct 14, 2024
59 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Oct 14, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 14, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 14, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 14, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@kevincai @mergify
[BugFix] Fix dataCacheInfo leak in idToDataCacheInfo (#51830)
cf07f6b 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 688714e)
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@kevincai @mergify
[BugFix] Fix dataCacheInfo leak in idToDataCacheInfo (#51830)
52f00a9 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 688714e)
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Oct 14, 2024
@kevincai @mergify
[BugFix] Fix dataCacheInfo leak in idToDataCacheInfo (#51830)
011f53f 
Signed-off-by: Kevin Xiaohua Cai <[email protected]>
(cherry picked from commit 688714e)
@mergify mergify bot mentioned this pull request Oct 14, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Oct 14, 2024
@mergify @kevincai
[BugFix] fix dataCacheInfo leak in idToDataCacheInfo (backport #51830) (
8f33a85 
#51864)

Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 14, 2024
@mergify @kevincai
[BugFix] fix dataCacheInfo leak in idToDataCacheInfo (backport #51830) (
0097a94 
#51866)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Oct 14, 2024
@mergify @kevincai
[BugFix] fix dataCacheInfo leak in idToDataCacheInfo (backport #51830) (
79b4e2b 
#51865)

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
Co-authored-by: Kevin Cai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decster decster decster approved these changes

@wyb wyb wyb approved these changes

Assignees

@kevincai kevincai

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevincai @decster @wyb