Iter20 #23
Merged
Iter20 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-логике сделал более аккуратную обработку ошибок
актуализировал вопросы
(см Questions.md)
отладился, прошел локальный тест
добавил тест
поправил форматирвоание
обновил вопросы
добавил маппинг внутренних ошибок на ошибки http
alekstet
reviewed
Jun 9, 2024
alekstet
reviewed
Jun 9, 2024
| err = invoker.Invoke(req.Context(), invokableFn) | ||
| if err != nil { | ||
| log.Errorw("RetriableRequestMW", "error", err.Error()) | ||
| http.Error(w, err.Error(), domain.MapDomainErrorToHTTPStatusErr(err)) |
There was a problem hiding this comment.
Ты когда печатаешь так ошибку в http ответ
Главное чтоб туда не просочились ошибки бизнес логики
alekstet
reviewed
Jun 9, 2024
| @@ -21,21 +22,7 @@ type storage struct { | |||
| databaseURL string | |||
| } | |||
|
|
|||
| var createCounterTableSQL = `CREATE TABLE IF NOT EXISTS counter( | |||
| name text not null, | |||
There was a problem hiding this comment.
Ну id обычный числовой все равно должен быть
There was a problem hiding this comment.
Не уверен что должен быть числовой ID.
После курса планирую "PostgreSQL 15 изнутри" изучить - оставлю пока вопрос открытым.
alekstet
reviewed
Jun 9, 2024
alekstet
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.