Merge pull request #632 from SteveDunn/refer-to-correct-exception-in-…

…comments

Fix generated code comments referring to default exception type

src/Vogen/GenerateCodeForParse.cs

@@ -87,7 +87,7 @@ private static string BuildParseWithFormatProviderMethodForAString(VoWorkItem it
     /// <returns>
     /// The value created via the <see cref=""From(global::System.String)""/> method.
     /// </returns>
-    /// <exception cref=""ValueObjectValidationException"">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref=""{item.ValidationExceptionFullName}"">Thrown when the value can be parsed, but is not valid.</exception>
     {methodDecl}(global::System.String s, global::System.IFormatProvider provider) {{
         return From(s);
     }}";
@@ -134,7 +134,7 @@ private static void BuildParseMethod(IMethodSymbol methodSymbol, StringBuilder s
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref=""ValueObjectValidationException"">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref=""{item.ValidationExceptionFullName}"">Thrown when the value can be parsed, but is not valid.</exception>
     public {staticOrNot}{item.VoTypeName} Parse({parameters}) {{
         var r = {item.UnderlyingTypeFullName}.Parse({parameterNames});
         return From(r);

src/Vogen/Generators/ClassGenerator.cs

@@ -27,7 +27,7 @@ public string BuildClass(VoWorkItem item, TypeDeclarationSyntax tds)
         private readonly {itemUnderlyingType} _value;
         
 /// <summary>
-/// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{nameof(ValueObjectValidationException)}"" /> is thrown.
+/// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{item.ValidationExceptionFullName}"" /> is thrown.
 /// </summary>
 public {itemUnderlyingType} Value
         {{

src/Vogen/Generators/RecordClassGenerator.cs

@@ -26,7 +26,7 @@ public string BuildClass(VoWorkItem item, TypeDeclarationSyntax tds)
         private readonly {itemUnderlyingType} _value;
         
         /// <summary>
-        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{nameof(ValueObjectValidationException)}"" /> is thrown.
+        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{item.ValidationExceptionFullName}"" /> is thrown.
         /// </summary>
         public {itemUnderlyingType} Value
         {{

src/Vogen/Generators/RecordStructGenerator.cs

@@ -28,7 +28,7 @@ public string BuildClass(VoWorkItem item, TypeDeclarationSyntax tds)
         private readonly {itemUnderlyingType} _value;
 
         /// <summary>
-        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{nameof(ValueObjectValidationException)}"" /> is thrown.
+        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{item.ValidationExceptionFullName}"" /> is thrown.
         /// </summary>
         public readonly {itemUnderlyingType} Value
         {{

src/Vogen/Generators/StructGenerator.cs

@@ -28,7 +28,7 @@ public string BuildClass(VoWorkItem item, TypeDeclarationSyntax tds)
         private readonly {itemUnderlyingType} _value;
 
         /// <summary>
-        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{nameof(ValueObjectValidationException)}"" /> is thrown.
+        /// Gets the underlying <see cref=""{itemUnderlyingType}"" /> value if set, otherwise a <see cref=""{item.ValidationExceptionFullName}"" /> is thrown.
         /// </summary>
         public readonly {itemUnderlyingType} Value
         {{

tests/SnapshotTests/BugFixes/snapshots/snap-v3.1/Bug575_AttributesWithArraysBreaksGenerator.Test.verified.txt

@@ -86,7 +86,7 @@ using Vogen;
         private readonly System.Int32 _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Int32 Value
         {
@@ -326,7 +326,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(global::System.ReadOnlySpan<char> s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -338,7 +338,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s) {
         var r = System.Int32.Parse(s);
         return From(r);
@@ -350,7 +350,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style) {
         var r = System.Int32.Parse(s, style);
         return From(r);
@@ -362,7 +362,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -374,7 +374,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, provider);
         return From(r);

tests/SnapshotTests/BugFixes/snapshots/snap-v3.1/Bug581_StjDeserializer_throws_correct_exception.Test.verified.txt

@@ -86,7 +86,7 @@ using Vogen;
         private readonly System.Guid _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Guid" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Guid" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Guid Value
         {
@@ -282,7 +282,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Guid value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(global::System.ReadOnlySpan<char> input) {
         var r = System.Guid.Parse(input);
         return From(r);
@@ -294,7 +294,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Guid value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string input) {
         var r = System.Guid.Parse(input);
         return From(r);

tests/SnapshotTests/BugFixes/snapshots/snap-v3.1/Bug595_AttributesWithArraysBreaksGenerator.Test.verified.txt

@@ -85,7 +85,7 @@ using Vogen;
         private readonly System.Int32 _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Int32 Value
         {
@@ -325,7 +325,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(global::System.ReadOnlySpan<char> s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -337,7 +337,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s) {
         var r = System.Int32.Parse(s);
         return From(r);
@@ -349,7 +349,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style) {
         var r = System.Int32.Parse(s, style);
         return From(r);
@@ -361,7 +361,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -373,7 +373,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, provider);
         return From(r);

tests/SnapshotTests/BugFixes/snapshots/snap-v4.6.1/Bug575_AttributesWithArraysBreaksGenerator.Test.verified.txt

@@ -86,7 +86,7 @@ using Vogen;
         private readonly System.Int32 _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Int32 Value
         {
@@ -282,7 +282,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s) {
         var r = System.Int32.Parse(s);
         return From(r);
@@ -294,7 +294,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style) {
         var r = System.Int32.Parse(s, style);
         return From(r);
@@ -306,7 +306,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -318,7 +318,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, provider);
         return From(r);

tests/SnapshotTests/BugFixes/snapshots/snap-v4.6.1/Bug581_StjDeserializer_throws_correct_exception.Test.verified.txt

@@ -86,7 +86,7 @@ using Vogen;
         private readonly System.Guid _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Guid" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Guid" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Guid Value
         {
@@ -260,7 +260,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Guid value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string input) {
         var r = System.Guid.Parse(input);
         return From(r);

tests/SnapshotTests/BugFixes/snapshots/snap-v4.6.1/Bug595_AttributesWithArraysBreaksGenerator.Test.verified.txt

@@ -85,7 +85,7 @@ using Vogen;
         private readonly System.Int32 _value;
 
         /// <summary>
-        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="ValueObjectValidationException" /> is thrown.
+        /// Gets the underlying <see cref="System.Int32" /> value if set, otherwise a <see cref="global::Vogen.ValueObjectValidationException" /> is thrown.
         /// </summary>
         public readonly System.Int32 Value
         {
@@ -281,7 +281,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s) {
         var r = System.Int32.Parse(s);
         return From(r);
@@ -293,7 +293,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style) {
         var r = System.Int32.Parse(s, style);
         return From(r);
@@ -305,7 +305,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.Globalization.NumberStyles style, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, style, provider);
         return From(r);
@@ -317,7 +317,7 @@ public static ValueObjectOrError<Vo> TryFrom(System.Int32 value)
     /// <returns>
     /// The value created by calling the Parse method on the primitive.
     /// </returns>
-    /// <exception cref="ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
+    /// <exception cref="global::Vogen.ValueObjectValidationException">Thrown when the value can be parsed, but is not valid.</exception>
     public static Vo Parse(string s, global::System.IFormatProvider provider) {
         var r = System.Int32.Parse(s, provider);
         return From(r);