fix: prefix STJ generated file namespace with global #654
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this today at work where STJ conversion generated code wasn't compiling. This was caused by the namespace looking something like
Abc.Def.Abc
which is a classic way to break source generators when they're not prefixing namespaces withglobal::
. This should fix the values of both the key & value'sLazy<T>
factory.This PR is crazy big because it shows up in almost every snapshot test. Adding these individually in path mode without zoning out was a real test.
Love ya' work Steve, keep doing what you're doing!