Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Developer] auto close redundant prs #12

Closed
wants to merge 6 commits into from

Conversation

ANS1514
Copy link
Contributor

@ANS1514 ANS1514 commented Sep 26, 2023

This will implement a github workflow that runs when SubmittyBot creates a PR. It will look through the current PRs open and close all of them except for the most recent one.

For testing I created my own repo and tested the workflow in that repo to find the right behavior

closes Submitty/Submitty#9741

@ANS1514 ANS1514 closed this Sep 26, 2023
@ANS1514 ANS1514 reopened this Sep 26, 2023
@skara9
Copy link
Contributor

skara9 commented Sep 29, 2023

We already have a workflow that creates a SubmittyBot PR. Creating a separate workflow triggered by the completion of this workflow might not be the best idea as it would add redundancy and slow things down.

Instead, we may want to consider revising the dependency update PR to do one of two things:
(a) Reuse the existing SubmittyBot PR rather than make a new one (very easy + avoids garbage)
(b) Close any existing SubmittyBot PRs prior to making the new one

@ANS1514 ANS1514 closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auto-close redundant version bump PRs in the Localization repo
2 participants