-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update dependencies and tooling #211
base: develop
Are you sure you want to change the base?
Conversation
"bufferutil": "^4.0.7", | ||
"casparcg-connection": "^6.0.6", | ||
"classnames": "^2.3.2", | ||
"@sofie-automation/sorensen": "patch:@sofie-automation/sorensen@npm%3A1.4.3#~/.yarn/patches/@sofie-automation-sorensen-npm-1.4.3-a11a53b994.patch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's up with the patches? Just esm-module fixes?
Should we PR the changes to the upstream modules as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sorensen one should be upstreamed, and is an esm fix.
The formik one is an incompatibility with updated react types, probably will go away when updating formik, but I didn't want to do a major bump of that yet.
The react-toggle ones are esm fixes, but upstream hasnt had a commit in 2 years, so I suspect trying to upstream it won't get anywhere.
I've looked through the commits up to this point, looks good! |
There is an issue with the sorensen library not loading in the builds, but ci produced builds do launch on windows and linux. macos is being stubborn, because of changes of the notarization flow. hopefully this will be resolved once a new secret is added |
To avoid crash when using Streamdecks on Ubuntu, see pr #212
Quality Gate passedIssues Measures |
This is a pretty large set of changes which tackles the following:
My primary testing has been both dev and packaged builds on linux, and it appears to be happy in both flows.
The built binaries need some additional testing on windows and macos, in particular checking that the ci produced macos builds run on both intel and arm.
If anyone wants to review this, I would suggest skimming each commit in turn. In particular the ones which convert things to esm are large, but mostly just change imports