Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file path for particle editor #3102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tobbi
Copy link
Member

@tobbi tobbi commented Nov 16, 2024

This uses the FileSystem methods for combining the path elements instead of some weird homemade stuff.

Closes #3103

@tobbi tobbi linked an issue Nov 16, 2024 that may be closed by this pull request
6 tasks
@swagtoy
Copy link

swagtoy commented Nov 16, 2024

Bahaha, looks good!

On a related note: We should move to std::filesystem soon, unless there are any objections. Feels okay to discuss here real quick

@Eauix
Copy link
Contributor

Eauix commented Nov 17, 2024

I tested it, but unfortunately the crash still happens the same way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Crash]: Loading a custom particle file from a subfolder causes a fatal exception
3 participants