-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow uniform access rules on upload #114
base: master
Are you sure you want to change the base?
Conversation
The tests are failing because they are not scoped to work with this use case. |
thanks @mattfoster7 for sharing this.
|
Shouldn't the This way user can omit the configuration if they don't want to use the |
Any news on this? Just for reference, this is the related question on StackOverflow: https://stackoverflow.com/questions/61779218/trying-to-upload-to-google-cloud-storage-using-superbalist-flysystem-google-clou |
Also curious about this one. |
Hi is there any progress with this pr? itd be great to get this change merged in! |
Hi, is this pr alive? This will solve problems for who can't change bucket access control 🙏 |
😭😭😭 Pls merge this pr🙏 |
Currently the code forces an ACL on the files, this doesn't work if the bucket has uniform access policies set. So this PR just checks whether the bucket has uniform access before setting the ACL.