Rename KProcess to KTermProcess to not BIC KF5CoreAddons KProcess #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is KProcess is copy-paste from kdebase libs 4, now it broke the BIC with KProcess from KF5CoreAddons which result in crash when run Termoid. |
|
I can confirm this also fixes issues when using Station (Maui terminal app) on KDE Neon and Manjaro, both desktop and phones.. Would be awesome to have it merged ASAP. :) |
Signed-off-by: Anthony Fieroni <[email protected]>
|
Patch added to OpenMandriva packages (and confirmed to fix index-fm crash on startup) as well |
|
@Swordfish90 could you merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anthony Fieroni [email protected]