Support multiple color scheme dirs #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there's no way for an application user to _add_ custom color schemes, since only the first of QML_INCLUDE_DIRS that includes the colorschemes dir is chosen, and COLORSCHEMES_DIR is overwritten inside the app. Use a colon-separated COLORSCHEMES_DIRS instead, which allows to set multiple dirs for color schemes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's no way for an application user or a distribution maintainer to add custom color
schemes, since only the first of QML_INCLUDE_DIRS that includes the
colorschemes dir is chosen, and COLORSCHEMES_DIR is overwritten inside
the app. Use a colon-separated COLORSCHEMES_DIRS instead, which allows
to set multiple dirs for color schemes.