Expression field #352
Open
Expression field #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florian-Merle
force-pushed
the
expression-field
branch
3 times, most recently
from
6def5c5 to
1fb1dda
Compare
Florian-Merle
force-pushed
the
expression-field
branch
from
1fb1dda to
678c268
Compare
loic425
reviewed
Nov 20, 2024
Florian-Merle
force-pushed
the
expression-field
branch
9 times, most recently
from
1b07253 to
7589179
Compare
Florian-Merle
force-pushed
the
expression-field
branch
2 times, most recently
from
7a02791 to
0a4881e
Compare
loic425
reviewed
Nov 28, 2024
|
|
||
| ```yaml | ||
| # config/packages/sylius_grid.yaml | ||
|
|
There was a problem hiding this comment.
This line break is present in all YAML/PHP examples in this file. Should I remove it?
loic425
reviewed
Nov 28, 2024
loic425
reviewed
Nov 28, 2024
| @@ -22,6 +22,13 @@ | |||
| </service> | |||
| <service id="sylius.grid_field.datetime" alias="Sylius\Component\Grid\FieldTypes\DatetimeFieldType" /> | |||
There was a problem hiding this comment.
Normally it has been flipped back. I have to check.
There was a problem hiding this comment.
I confirmed, I think your branch is not up to date.
There was a problem hiding this comment.
No!! @GSadee, you forgot the upmerge from 1.13 to 1.14
There was a problem hiding this comment.
I updated the config files
Florian-Merle
force-pushed
the
expression-field
branch
from
0a4881e to
20c2258
Compare
diimpp
reviewed
Dec 5, 2024
composer.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "symfony/dependency-injection": "^5.4 || ^6.4 || ^7.0", | |||
| "symfony/deprecation-contracts": "^2.2 || ^3.1", | |||
| "symfony/event-dispatcher": "^5.4 || ^6.4 || ^7.0", | |||
| "symfony/expression-language": "^5.4 || ^6.0 || ^7.0", | |||
There was a problem hiding this comment.
Suggested change
| "symfony/expression-language": "^5.4 || ^6.0 || ^7.0", | |
| "symfony/expression-language": "^5.4 || ^6.4 || ^7.0", |
docs/field_types.md
Outdated
| Expression | ||
| ---------- | ||
|
|
||
| The **Expression** column provides flexibility by allowing you to specify an expression that will be evaluated on the fly. |
There was a problem hiding this comment.
Suggested change
| The **Expression** column provides flexibility by allowing you to specify an expression that will be evaluated on the fly. | |
| The **Expression** field type provides flexibility by allowing you to specify an expression that will be evaluated on the fly. |
docs/field_types.md
Outdated
| label: app.ui.price | ||
| options: | ||
| expression: 'value ~ "$"' | ||
|
|
docs/field_types.md
Outdated
| options: | ||
| expression: '"<strong>" ~ value ~ "</strong>"' | ||
| htmlspecialchars: false | ||
|
|
| @@ -36,3 +43,4 @@ | |||
| <service id="Sylius\Bundle\GridBundle\FieldTypes\TwigFieldType" alias="sylius.grid_field.twig" /> | |||
| </services> | |||
| </container> | |||
|
|
|||
src/Component/composer.json
Outdated
| @@ -34,6 +34,7 @@ | |||
| "symfony/config": "^5.4 || ^6.4 || ^7.0", | |||
| "symfony/deprecation-contracts": "^2.2", | |||
| "symfony/event-dispatcher": "^5.4 || ^6.4 || ^7.0", | |||
| "symfony/expression-language": "^5.4 || ^6.0 || ^7.0", | |||
There was a problem hiding this comment.
Suggested change
| "symfony/expression-language": "^5.4 || ^6.0 || ^7.0", | |
| "symfony/expression-language": "^5.4 || ^6.4 || ^7.0", |
| <service id="sylius_grid.expression_language" class="Symfony\Component\ExpressionLanguage\ExpressionLanguage"> | ||
| <factory service="sylius_grid.expression_language.factory" /> | ||
| </service> | ||
| <service id="Symfony\Component\ExpressionLanguage\ExpressionLanguage" alias="sylius_grid.expression_language" /> |
There was a problem hiding this comment.
I don't think we can use symfony vendor class as alias for our locale expression language instance.
There was a problem hiding this comment.
Yep, I did this without thinking
Florian-Merle
force-pushed
the
expression-field
branch
from
20c2258 to
eed11b4
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.