-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py310-py311: Update to latest wheel and rework numpy management #5531
Conversation
d86d04f
to
20a1396
Compare
90ce646
to
090aca2
Compare
@th0ma7 I am currently updating #5399 with actual python310 and get this warning while cross compiling wheels:
This is just a hint, as I didn't analyze what you are working on here. EDIT:
|
@hgy59 thnx for the hint. I've took a few cycles to analyse the issue and really there isn't yet any. What is really frustrating is the complete lack of documentation of both As such, these two non-issues will be handled at some other time, perhaps at a subsequent |
@Safihre would you mind testing out py311 package resulting from the last commit? (currently building) EDIT: BTW, this solves the |
Both py310-py311 where successfully tested on DSM6 and DSM7. Merging. |
# - CFLAGS=-sdt=c99 < gcc-4.9 | ||
# - CFLAGS=-sdt=c11 >= gcc-4.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: std (not sdt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch... Gladly its ok in the makefile :)
@th0ma7 shouldn't the wheels installed into crossenv be of the same version as in requirements-pure.txt files? and setuptools should match the version in native/python310/Makefile and native/python311/Makefile so far only setuptools differ
When building crossenv wheels I faced uninstall setuptools logs for every wheel... |
@hgy59 sharp eyes... indeed normally all versions are identical, from Issue relates to numpy building from the With the newer py311 we can no longer support version 1.21.x for Lastly, I haven't tested with latest and greates |
Description
Update to latest wheels and fully test all of them for both py3.10-3.11
Fixes #
Checklist
all-supported
completed successfullyType of change