Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glib build fix with libiconv #6043

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Mar 21, 2024

Description

MPD update+build fix and glib + libiconv fix

Relates to #6040

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 changed the title Glib iconv fix MPD update+build fix and glib + libiconv fix Mar 22, 2024
@th0ma7 th0ma7 self-assigned this Mar 22, 2024
@hgy59
Copy link
Contributor

hgy59 commented Mar 22, 2024

@th0ma7 I have #5652 in progress.

It already builds for DSM 7+ only.
Is there anything missing in #5652 beside the update from 0.23.12 to 0.23.15?

@th0ma7
Copy link
Contributor Author

th0ma7 commented Mar 23, 2024

I wasn't intending to update mpd at first but focus was to solve glib use case. It turned out that mpd needed attention to get it all to build properly.

Anyhow, I can certainly remove the mpd portion of this PR. My focus is to fix glib for #6040 to limiting massive rebuild time. Are you ok with me merging only the glib bits then?

@hgy59
Copy link
Contributor

hgy59 commented Mar 23, 2024

Anyhow, I can certainly remove the mpd portion of this PR. My focus is to fix glib for #6040 to limiting massive rebuild time. Are you ok with me merging only the glib bits then?

Yes that's ok. I will wait with #5652 until you merged the glib bits...

@th0ma7 th0ma7 changed the title MPD update+build fix and glib + libiconv fix glib build fix with libiconv Mar 23, 2024
@th0ma7 th0ma7 merged commit 744134e into SynoCommunity:master Mar 23, 2024
9 of 19 checks passed
@th0ma7
Copy link
Contributor Author

th0ma7 commented Mar 23, 2024

Yes that's ok. I will wait with #5652 until you merged the glib bits...

@hgy59 done!

@th0ma7 th0ma7 deleted the glib-iconv-fix branch March 23, 2024 14:10
@hgy59
Copy link
Contributor

hgy59 commented Mar 23, 2024

@th0ma7 why does the build of mpd (without update) fail?

@th0ma7
Copy link
Contributor Author

th0ma7 commented Mar 23, 2024

So in one case you get glib failing due to libiconv (issue that is resolved with newer glib). In turn, on the faulty glib, when fixing build by enforcing external libiconv it ends up making mpd to fail as well. Again fixed with newer mpd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants